Skip to content

CE destroy repo mirrors

Luke Bennett requested to merge its-simple-just-destroy-the-mirrors into master

What does this MR do?

CE port of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10355

destroy repo mirrors when the delete button is clicked.

it is important to destroy instead of disable because it opaquely leaves sensitive data in the DB that could worsen a breach.

Use _destroy nested attribute instead of enabled for push mirrors.

Call remove_import_data after saving a project if its pull mirror is disabled.

Does this MR meet the acceptance criteria?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54574

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports