Skip to content

EE destroy repo mirrors

Luke Bennett requested to merge its-simple-just-destroy-the-mirrors into master

What does this MR do?

CE port: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27087

destroy repo mirrors when the delete button is clicked.

it is important to destroy instead of disable because it opaquely leaves sensitive data in the DB that could worsen a breach.

Use _destroy nested attribute instead of enabled for push mirrors.

Call remove_import_data after saving a project if its pull mirror is disabled.


Because of remove_import_data if mirror? == false on save, we can no longer show users their public ssh key before they have saved the mirror.

We now use the same UX as push mirrors and provide the ssh public key through a copy to clipboard button in the mirrors table.

Screenshot_2019-04-07_at_18.03.03

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54574

Does this MR meet the acceptance criteria?

Edited by 🤖 GitLab Bot 🤖

Merge request reports