Add gitlab-managed option to clusters form (!26565) · Merge Requests · GitLab.org / GitLab FOSS

Add gitlab-managed option to clusters form

What does this MR do?

Add "gitlab-managed" option to Clusters form

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/56557

Does this MR meet the acceptance criteria?

Changelog entry added, if necessary
Documentation created/updated via this MR
Documentation reviewed by technical writer or follow-up review issue created
Tests added for this feature/bug
[-] Tested in all supported browsers
Conforms to the code review guidelines
Conforms to the merge request performance guidelines
Conforms to the style guides
[-] Conforms to the database guides
[-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
[-] Security reports checked/validated by reviewer

Closes #56557 (closed)

Backend - todo

Add a new column to Clusters::Cluster. It could be:
- Boolean managed. In this case, we need to default to true - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26675
Rename current Clusters::Cluster#managed? method to user_provided?, so we can use managed? - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26567
Add the new field in the view, pass it to the controller and ensure is saved in database. - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26096
Ensure this field is not editable on the Cluster form after the cluster has been created
If managed avoid creation of Kubernetes resources for GCP and user clusters.
- When ci_preparing_state is not enabled
- When ci_preparing_state is enabled
Manual QA

Manual QA - When `ci_preparing_state` is not enabled

Clusters managed by GitLab

GCP-provided cluster	Resources created	User-provided cluster	Resources created

Clusters not managed by GitLab

Cluster managed by GitLab	Resources created	User-provided cluster	No Resources created

Manual QA - When `ci_preparing_state` is enbled

GCP Cluster managed by GitLab

Cluster	Resources before ADO pipeline	Pipeline	Resources after ADO pipeline	URL

GCP Cluster not-managed by GitLab

Cluster	Resources before ADO pipeline	Pipeline (fails due to missing namespace)	Resources after ADO pipeline

## What does this MR do?

Add "gitlab-managed" option to Clusters form

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/56557

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) added, if necessary
- [x] [Documentation created/updated](https://docs.gitlab.com/ee/development/documentation/feature-change-workflow.html) via this MR
- [x] Documentation reviewed by technical writer *or* follow-up review issue [created](https://gitlab.com/gitlab-org/gitlab-ce/issues/new?issuable_template=Doc%20Review)
- [x] [Tests added for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html)
- [-] Tested in [all supported browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers)
- [x] Conforms to the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
- [x] Conforms to the [merge request performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] Conforms to the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides)
- [-] Conforms to the [database guides](https://docs.gitlab.com/ee/development/README.html#database-guides)
- [-] Link to e2e tests MR added if this MR has ~"Requires e2e tests" label. See the [Test Planning Process](https://about.gitlab.com/handbook/engineering/quality/guidelines/test-engineering/).
- [-] Security reports checked/validated by reviewer

Closes #56557

### Backend - todo

* [x] Add a new column to `Clusters::Cluster`. It could be:
   * Boolean `managed`. In this case, we need to default to `true` - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26675
* [x] Rename current `Clusters::Cluster#managed?` method to `user_provided?`, so we can use `managed?` - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26567
* [x] Add the new field in the view, pass it to the controller and ensure is saved in database. - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26096
* [x] Ensure this field is not editable on the Cluster form after the cluster has been created
* [x] If `managed` avoid creation of Kubernetes resources for GCP and user clusters.
   * [x] When `ci_preparing_state` is not enabled
   * [x] When `ci_preparing_state` is enabled
* [x]  Manual QA
  
## Manual QA - When `ci_preparing_state` is not enabled
 
### Clusters managed by GitLab

| GCP-provided cluster  | Resources created | User-provided cluster | Resources created |
| ------ | ------ | ------ | ------ |
| ![Screen_Shot_2019-04-03_at_2.11.17_PM](/uploads/0567abc3f57deae2b4492f96e6ac44d6/Screen_Shot_2019-04-03_at_2.11.17_PM.png) | ![Screen_Shot_2019-04-03_at_2.12.33_PM](/uploads/12809056cc3ceafdc54649e3f884bd3c/Screen_Shot_2019-04-03_at_2.12.33_PM.png) | ![Screen_Shot_2019-04-03_at_2.45.36_PM](/uploads/7b0cedb8ee80555e0e23302e30aabd6b/Screen_Shot_2019-04-03_at_2.45.36_PM.png) | ![Screen_Shot_2019-04-03_at_2.46.18_PM](/uploads/52ac3292771d881fd86b4b1997928b7b/Screen_Shot_2019-04-03_at_2.46.18_PM.png) |

### Clusters not managed by GitLab

| Cluster managed by GitLab | Resources created | User-provided cluster | No Resources created |
| ------ | ------ | ------ | ------ |
| ![Screen_Shot_2019-04-03_at_2.30.12_PM](/uploads/8ed7150dfe390c71391130aa1fc7ed7a/Screen_Shot_2019-04-03_at_2.30.12_PM.png) | ![Screen_Shot_2019-04-03_at_2.30.23_PM](/uploads/c2bb0c76227f2eb34f3939e53a65715f/Screen_Shot_2019-04-03_at_2.30.23_PM.png) |  ![Screen_Shot_2019-04-03_at_3.39.45_PM](/uploads/3a0048ce1ecde2fc3f97ef6f1e43061a/Screen_Shot_2019-04-03_at_3.39.45_PM.png) | ![Screen_Shot_2019-04-03_at_3.40.05_PM](/uploads/2de2248b1f7868d9c98161535c0b5d13/Screen_Shot_2019-04-03_at_3.40.05_PM.png) |

## Manual QA - When `ci_preparing_state` is enbled

### GCP Cluster managed by GitLab

| Cluster | Resources before ADO pipeline | Pipeline | Resources after ADO pipeline | URL |
| ------ | ------ | ------ | ------ | ------ |
| ![cluster_detail](/uploads/c309599ade36e085f6a92c36804e6d5b/cluster_detail.png) | ![console_no_namespace](/uploads/73a733b8672b472085966e578db648ea/console_no_namespace.png) | ![pipeline](/uploads/b8480428110fff4e7f7de47a50ccaf5a/pipeline.png) | ![console_namespace](/uploads/65d925f385c2b1c551220cf8dd540544/console_namespace.png) | ![web_page](/uploads/cf5c4f7c1615e51807712cdc9f8c6548/web_page.png) |

### GCP Cluster not-managed by GitLab

| Cluster | Resources before ADO pipeline | Pipeline (fails due to missing namespace) | Resources after ADO pipeline |
| ------ | ------ | ------ | ------ |
| ![cluster_detail](/uploads/683b01cfcb1ec894742c075d2e2b3d9f/image.png) | ![console_no_namespace](/uploads/02d7cac5a3b034974ad1f277501aead4/image.png) | ![pipeline](/uploads/60d16bfacc306a8c2a8a1b8777b3f516/image.png) | ![console_namespace](/uploads/377f570112497c120571514281a249be/image.png) |

Edited Apr 15, 2019 by Tiger Watson