Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !26565

Add gitlab-managed option to clusters form

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mayra Cabrera requested to merge 56557-disable-kubernetes-namespace-service-account-backend into master Mar 25, 2019
  • Overview 68
  • Commits 11
  • Pipelines 37
  • Changes 24

What does this MR do?

Add "gitlab-managed" option to Clusters form

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/56557

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated via this MR
  • Documentation reviewed by technical writer or follow-up review issue created
  • Tests added for this feature/bug
  • [-] Tested in all supported browsers
  • Conforms to the code review guidelines
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • [-] Conforms to the database guides
  • [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
  • [-] Security reports checked/validated by reviewer

Closes #56557 (closed)

Backend - todo

  • Add a new column to Clusters::Cluster. It could be:
    • Boolean managed. In this case, we need to default to true - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26675
  • Rename current Clusters::Cluster#managed? method to user_provided?, so we can use managed? - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26567
  • Add the new field in the view, pass it to the controller and ensure is saved in database. - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26096
  • Ensure this field is not editable on the Cluster form after the cluster has been created
  • If managed avoid creation of Kubernetes resources for GCP and user clusters.
    • When ci_preparing_state is not enabled
    • When ci_preparing_state is enabled
  • Manual QA

Manual QA - When ci_preparing_state is not enabled

Clusters managed by GitLab

GCP-provided cluster Resources created User-provided cluster  Resources created
Screen_Shot_2019-04-03_at_2.11.17_PM Screen_Shot_2019-04-03_at_2.12.33_PM Screen_Shot_2019-04-03_at_2.45.36_PM Screen_Shot_2019-04-03_at_2.46.18_PM

Clusters not managed by GitLab

Cluster managed by GitLab Resources created User-provided cluster No Resources created
Screen_Shot_2019-04-03_at_2.30.12_PM Screen_Shot_2019-04-03_at_2.30.23_PM Screen_Shot_2019-04-03_at_3.39.45_PM Screen_Shot_2019-04-03_at_3.40.05_PM

Manual QA - When ci_preparing_state is enbled

GCP Cluster managed by GitLab

Cluster Resources before ADO pipeline Pipeline Resources after ADO pipeline  URL
cluster_detail console_no_namespace pipeline console_namespace web_page

GCP Cluster not-managed by GitLab

Cluster Resources before ADO pipeline Pipeline (fails due to missing namespace) Resources after ADO pipeline
cluster_detail console_no_namespace pipeline console_namespace
Edited Apr 15, 2019 by Tiger Watson
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 56557-disable-kubernetes-namespace-service-account-backend