Fix the .review-deploy-base job so that env variables are passed
requested to merge 59113-review-apps-initial-seeding-is-broken-due-to-runners_registration_token-openssl-cipher-ciphererror-error-somehow into master
What does this MR do?
Environment variables defined in a before_script are not available in an after_script, hence Review Apps were deployed with broken Gitaly and GitLab Shell components, making the review-qa-smoke job failing every time.
This fixes it by running the deployment steps in the script part of the jobs.
What are the relevant issue numbers?
Closes #59113 (closed).
Does this MR meet the acceptance criteria?
-
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Security reports checked/validated by reviewer
Edited by Nick Thomas