Skip to content

Add control for masking variable values in runner logs

Miranda Fluharty requested to merge 13784-validate-variables-for-masking into master

What does this MR do?

Minimal version:

  • Add a "Masked" toggle to the Variables section
  • Check values against regex/rules that check if the value is suitable for masking
  • Still allow user to save values that don't match, as long as they've been warned
  • Update paragraph above to explain how this works

🌟 Ideal version here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25540

"Suitable for masking" means:

  • it should be a single line
  • it should not have escape characters
  • it should not use variables
  • it should not have any whitespace
  • it should be longer than 8 characters

Screenshots

Screen_Shot_2019-02-27_at_12.06.32

Screen_Shot_2019-02-27_at_12.09.12

What are the relevant issue numbers?

#59318 (moved), closes #13784 (closed)

Does this MR meet the acceptance criteria?

Edited by Kamil Trzciński

Merge request reports