Skip to content

Fine-tune Review Apps pod resource requests

Rémy Coutable requested to merge fine-tune-review-app-resource-requests into master

What does this MR do?

GKE autoscaler is solely based on the requested resources, not the actually used resources, hence the possibility that a node is under CPU/memory pressure, and no new nodes are created.

See https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler?hl=en_US&_ga=2.204280471.-687562060.1533737393.

Cluster autoscaler works based on Pod resource requests, based on how many resources your Pods have requested. Cluster autoscaler does not take into account the resources your Pods are actively using. Essentially, cluster autoscaler trusts that the Pod resource requests you've provided are accurate and schedules Pods on nodes based on that assumption.

If your Pods have requested too few resources (or haven't changed the defaults, which might be insufficient) and your nodes are experiencing shortages, cluster autoscaler does not correct the situation. You can help ensure cluster autoscaler works as accurately as possible by making explicit resource requests for all of your workloads.

What are the relevant issue numbers?

Relates to https://gitlab.com/charts/gitlab/issues/1107.

Does this MR meet the acceptance criteria?

Merge request reports