Move the CNG triggering to a dedicated job in the `test` stage
What does this MR do?
This is to save between 5 and 16 minutes upon retries of the review-deploy
job, see https://gitlab.com/gitlab-org/gitlab-ce/issues/56538#note_133412287.
What are the relevant issue numbers?
Closes #56660 (closed).
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %11.8
added QA Quality backstage [DEPRECATED] ci-build labels
added 1 commit
- 36ea41f2 - Move the CNG triggering to a new review-build-cng job
added 1 commit
- a6d9e869 - Move the CNG triggering to a new review-build-cng job
added 1 commit
- 988cddae - Move the CNG triggering to a new review-build-cng job
3 Warnings This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. The title of this merge request is longer than 72 characters and would violate our commit message rules when using the Squash on Merge feature. Please consider adjusting the title, or rebase the commits manually and don’t use Squash on Merge. 988cddae: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Generated by
Dangerassigned to @rymai
@godfat Could you please review? Thanks!
assigned to @godfat
- Resolved by Achilleas Pipinellis
- Resolved by Rémy Coutable
@rymai Thank you for helping me understand more about this! Just one small remark and one small question, but it looks good to me so I am approving. Please feel free to merge it :)
assigned to @rymai
@rymai Thank you! I feel we can probably cleanup some configurations because it's getting complex but that can be a lot of works due to technical limitation... Let's iterate fast first :D
assigned to @godfat
mentioned in commit 1077328b
mentioned in commit b146d71d
mentioned in merge request !24575 (closed)
@rymai I think this should be limited to branches and tags.
review-build-cng
is failing for forks. See https://gitlab.com/gtsiolis/gitlab-ce/-/jobs/149507927. /cc @godfatEdited by George Tsiolismentioned in issue #56707 (closed)
mentioned in merge request !24579 (merged)
@gtsiolis Yes, thanks and sorry for breaking it. I created https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24579
mentioned in merge request !24597 (merged)
mentioned in issue #56731 (closed)
mentioned in merge request !24861 (merged)