Skip to content
Snippets Groups Projects

Move the CNG triggering to a dedicated job in the `test` stage

All threads resolved!

What does this MR do?

This is to save between 5 and 16 minutes upon retries of the review-deploy job, see https://gitlab.com/gitlab-org/gitlab-ce/issues/56538#note_133412287.

What are the relevant issue numbers?

Closes #56660 (closed).

Does this MR meet the acceptance criteria?

Edited by Rémy Coutable

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lin Jen-Shin
  • Lin Jen-Shin approved this merge request

    approved this merge request

  • @rymai Thank you for helping me understand more about this! Just one small remark and one small question, but it looks good to me so I am approving. Please feel free to merge it :)

  • assigned to @rymai

  • Lin Jen-Shin resolved all discussions

    resolved all discussions

  • @rymai Thank you! I feel we can probably cleanup some configurations because it's getting complex but that can be a lot of works due to technical limitation... Let's iterate fast first :D

  • assigned to @godfat

  • merged

  • Lin Jen-Shin mentioned in commit 1077328b

    mentioned in commit 1077328b

  • Rémy Coutable resolved all discussions

    resolved all discussions

  • mentioned in commit b146d71d

  • mentioned in merge request !24575 (closed)

  • @rymai I think this should be limited to branches and tags. review-build-cng is failing for forks. See https://gitlab.com/gtsiolis/gitlab-ce/-/jobs/149507927. /cc @godfat

    Edited by George Tsiolis
  • mentioned in issue #56707 (closed)

  • Lin Jen-Shin mentioned in merge request !24579 (merged)

    mentioned in merge request !24579 (merged)

  • @gtsiolis Yes, thanks and sorry for breaking it. I created https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24579

  • Rémy Coutable mentioned in merge request !24597 (merged)

    mentioned in merge request !24597 (merged)

  • mentioned in issue #56731 (closed)

  • Lin Jen-Shin mentioned in merge request !24861 (merged)

    mentioned in merge request !24861 (merged)

  • Please register or sign in to reply
    Loading