Skip to content

Improve the handling of tags and branches which contains a `/` when triggering CNG pipelines

Rémy Coutable requested to merge qa/testing/cng/189 into master

What does this MR do?

  1. This uses CI_COMMIT_REF_NAME for GITLAB_REF_SLUG in scripts/trigger-build in the case of a tag. This is to ensure that tags are kept as-is and not slugified. This is a prerequisite for gitlab-org/build/CNG!189 (merged).
  2. This now passes GITLAB_VERSION instead of GITLAB_CE_VERSION/GITLAB_EE_VERSION to the triggered CNG pipeline because there was no reason to include the edition in the variable name.
  3. This now passes GITLAB_ASSETS_TAG to the triggered CNG pipeline so that gitlab-{ce,ee} is the SSOT for this assets tag (since the assets image is built in scripts/build_assets_image.
  4. This uses $CI_COMMIT_REF_SLUG in scripts/review_apps/review-apps.sh instead of $CI_COMMIT_REF_NAME so that / are replaced by -, now that the CNG pipeline will use GITLAB_REF_SLUG to tag the various CNG images (see gitlab-org/build/CNG!189 (merged)).

What are the relevant issue numbers?

Related to https://gitlab.com/charts/gitlab/issues/1068.

Does this MR meet the acceptance criteria?

Edited by Rémy Coutable

Merge request reports