Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 0
    • Merge requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !23922

Merged
Created Dec 18, 2018 by Mayra Cabrera@mayra-cabrera⚡Maintainer12 of 12 tasks completed12/12 tasks

Add API Support for Kubernetes integration

  • Overview 47
  • Commits 1
  • Pipelines 21
  • Changes 5

What does this MR do?

Add Kubernetes Integration for the following endpoints:

GET :id/clusters # Returns project clusters
GET :id/clusters/:cluster_id # Returns specific cluster
POST :id/clusters/user # Add a cluster to the project. Same as "Add existing Cluster" from UI
PUT :id/clusters/:cluster_id # Update existing cluster
DELETE :id/clusters/:cluster_id # Removes cluster

EE counterpart: gitlab-ee!8994

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/40473

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated -https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24135
  • Tests added for this feature/bug
  • [-] Tested in all supported browsers
  • Conforms to the code review guidelines
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • [-] Conforms to the database guides
  • [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
  • [-] Security reports checked/validated by reviewer

Backend - To do

  • List all clusters
  • Get specific cluster
  • Add existing cluster
  • Update a cluster
  • Destroy a cluster
  • Manual QA

Manual QA

Manual QA was done using an EE environment

GET :id/clusters - Returns project clusters

With developer & maintainer access

index

GET :id/clusters/:cluster_id - Returns specific cluster

With developer & maintainer access

GET

POST :id/clusters/user - Add a cluster to the project. Same as "Add existing Cluster" from UI

With valid params With invalid params

POST_valid

POST_invalid

PUT :id/clusters/:cluster_id - Update existing cluster

With user cluster With gcp cluster

PUT_USEr

PUT_GCP

DELETE :id/clusters/:cluster_id - Removes cluster

With existing cluster With unknown cluster

DELETE

DELETE_unknown

Edited Jan 05, 2019 by Kamil Trzciński
Assignee
Assign to
Reviewer
Request review from
11.7
Milestone
11.7 (Past due)
Assign milestone
Time tracking
Source branch: 40473-api-support-for-kubernetes-integration