Skip to content

Fix gitlab:web_hook tasks

Nick Thomas requested to merge (removed):54975-fix-web-hooks-rake-task into master

What does this MR do?

Fixes the gitlab:web_hook:rm task, and performs a number of small cleanups in the add and list tasks too. Adds tests for all three tasks.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22199 broke the gitlab:web_hook:rm task because we can no longer search for hooks by URL. There is a badly-performing workaround that we can do, where we scan the whole database (or a namespace-delimited subset thereof), which this MR represents.

Since these rake tasks are very old (introduced in 2013, not updated significantly since), they do a bunch of things in odd ways. I've cleaned up some of this, for instance, removing support for projects that are in no namespace at all.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Closes #54975 (closed)

Edited by Nick Thomas

Merge request reports