Skip to content

Prevent admins from attempting hashed storage migration on read only DB

Michael Kozono requested to merge mk/avoid-read-only-error into master

What does this MR do?

I noticed this small potential for confusion while working on https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8433. The warnings introduced in that MR prompt an admin to migrate to hashed storage for Geo. And that may cause them to try it on a Geo secondary, which will just error in a strange way.

It was noted that this problem exists not just for Geo secondaries, but for any GitLab instance with a read-only DB, so I'm fixing it in CE.

I am open to suggestions on the wording of the message.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Michael Kozono

Merge request reports