Fix styling of snippet and commit discussion comments
Since snippet and commit discussion comments haven't been rewritten in Vue, this is a placeholder to do basic styling. See https://gitlab.com/gitlab-org/gitlab-ce/issues/53918#note_117038785
Before | After |
---|---|
![]() |
![]() |
Closes #53918 (closed)
Merge request reports
Activity
assigned to @fatihacet
3 Warnings ⚠ CHANGELOG missing. You can create one with:
bin/changelog -m 23035 "Fix styling of snippet and commit discussion comments"
If your merge request doesn’t warrant a CHANGELOG entry,
consider adding any of the ~backstage, ~Documentation, QA, test labels.
See the documentation.⚠ You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, ~Documentation, QA labels.⚠ 973c5240: This commit’s subject line could be improved. Commit subjects are ideally no longer than roughly 50 characters, though we allow up to 72 characters in the subject. If possible, try to reduce the length of the subject to roughly 50 characters. Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Fatih Acet
@annabeldunstone LGTM. Nice to see that you could do this without too many changes.
I have a question. How about removing the avatar from the header and make it a little bit smaller? Something like this
My concern is since we have borders around the notes and having the avatar in the first box feels like a note but actually it isn't. Also if the note never updated, it will look like the body of the note is missing.
🤔 What do you think @annabeldunstone?
- Resolved by Fatih Acet
@annabeldunstone also discussion reply form is still broken
😞 Edited by Fatih Acet
mentioned in issue #53918 (closed)
added 1 commit
- 973c5240 - Fix styling of snippet and commit discussion comments
LGTM. Thanks @annabeldunstone
👍 mentioned in commit e9d6651f
Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23601, will merge into
11-5-stable
ready for11.5 RC9
mentioned in commit 3bafeb36
mentioned in issue gitlab-org/release/tasks#534 (closed)
mentioned in issue gitlab-org/release/tasks#576 (closed)