Link issues together to show that they're related or that one is blocking others.
Learn more.
Activity
Sort or filter
Newest first
Oldest first
Show all activity
Show comments only
Show history only
Fatih Acetchanged title from Comment and snippet discussions are broken after discussions redesign to Commit and snippet discussions are broken after discussions redesign
changed title from Comment and snippet discussions are broken after discussions redesign to Commit and snippet discussions are broken after discussions redesign
However, discussions in Commit and Snippets are still broken and currently look like
and it supposed to look like
Unfortunately, Commit and Snippets notes still rendered using old notes.js and Haml templates. They are still not Vue components. Now, trying to make them to look like what we did with redesign is not something easy. It would require too much changes on Haml templates and legacy notes.js.
@victorwu@andr3 what should we do about this issue? Any suggestions?
By the way, @annabeldunstone said that she will try to come up with an idea to make it looking acceptable.
@victorwu I cannot think a better way. Two concerns:
Discussions across GitLab will not be consistent
Technically it means, we should conditionally revert some of the redesign changes for Commit and Snippet discussions which is not ideal and create a technical debt.
I think it's close to what we used to have. Not ideal, but better than it looks currently. @victorwu could we schedule a rewrite of this code into a Vue component so it'll look like the rest of the discussion comments?
Yeah, scheduling the Commit and Snippet discussions for a rewrite with Vue would be really useful. We can get rid of the notes.js and bunch of Haml templates. Plus, we will have consistent design and codebase.