Skip to content

Revert "Merge branch 'winh-prettier-job-app' into 'master'"

Filipa Lacerda requested to merge revert-62d8b906 into master

What does this MR do?

I'm deeply sorry, but I have to revert this MR for %11.5

The reason is that prettier wasn't run on %11.4 and the refactoring of the job show page still has regressions.

This MR caused a lot of conflicts in the open MRs that are fixing the regressions. Which means that this conflicts will happen again when the regressions are picked and this will block Release Managers.

Prettier is not a blocker for other deliverables. The code within jobs/ will not be prettified before %11.5

Running prettier in code under jobs/ folder is on my todo list and will happen in %11.6. Until then, for the sake of not blocking a patch release with this, we are not going to run prettier in this code.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22463#note_110193761 https://gitlab.com/gitlab-org/gitlab-ce/issues/52854

Merge request reports