Skip to content

Add `TOP_UPSTREAM_SOURCE_SHA` in `scripts/trigger-build`

Rémy Coutable requested to merge add-top_upstream_source_sha-in-trigger-build into master

What does this MR do?

Pass 'TOP_UPSTREAM_SOURCE_SHA' in trigger-build

This is needed because `GITLAB_VERSION` has a special meaning in
`omnibus-gitlab` triggers: this is the GitLab version to build.

The problem is that `omnibus-gitlab` also has triggers to run QA for an
`omnibus-gitlab` commit, and if we use `GITLAB_VERSION` in that case,
the comment would be posted on the GitLab CE/EE commit (stored in
`GITLAB_VERSION`), whci hwouldn't make any sense.
Thus we need `TOP_UPSTREAM_SOURCE_SHA` to represent the commit on
which we want to leave a comment.

and

Improve the variables passed in trigger-build

Make the variable names consistent by following the
`TOP_UPSTREAM_SOURCE_*` pattern.

What are the relevant issue numbers?

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/47818 and omnibus-gitlab!2764 (merged).

Does this MR meet the acceptance criteria?

Merge request reports