Skip to content

[QA] Re-add Test::Instance for back-compatibility with GitLab < 11.3

Rémy Coutable requested to merge make-qa-scenario-test-instance-back-compatible into master

What does this MR do?

  # This class exists for back-compatibility so that gitlab-qa can continue
  # to call Test::Instance instead of Test::Instance::All until at least
  # the current latest GitLab version has the Test::Instance::All class.
  # As of Aug, 22nd 2018. Only GitLab >= 11.3 has this class.

I tested it locally and it worked:

› GITLAB_USERNAME="root" GITLAB_PASSWORD="5iveL\!fe" bin/qa Test::Instance::Any gitlab/gitlab-ce-qa:make-qa-scenario-test-instance-back-compatible http://192.168.0.12:3000 -- qa/specs/features/project/create_spec.rb

Running test suite `Test::Instance` for gitlab-ce
Docker shell command: `docker run -t --rm --net=bridge --env GITLAB_USERNAME="$GITLAB_USERNAME" --env GITLAB_PASSWORD="$GITLAB_PASSWORD" --env GITLAB_QA_ACCESS_TOKEN="$GITLAB_QA_ACCESS_TOKEN" --env GITHUB_ACCESS_TOKEN="$GITHUB_ACCESS_TOKEN" --volume /var/run/docker.sock:/var/run/docker.sock:z --volume /tmp/gitlab-qa/gitlab-qa-run-2018-08-22-09-30-33-2c6e9a01/gitlab-ce-qa-a09886b1:/home/qa/tmp:z --name gitlab-ce-qa-a09886b1 gitlab/gitlab-ce-qa:make-qa-scenario-test-instance-back-compatible Test::Instance http://192.168.0.12:3000 -- qa/specs/features/project/create_spec.rb`
Run options: exclude {:orchestrated=>true}

Randomized with seed 55076

create a new project
  user creates a new project

Top 1 slowest examples (29.27 seconds, 100.0% of total time):
  create a new project user creates a new project
    29.27 seconds ./qa/specs/features/project/create_spec.rb:3

Finished in 29.27 seconds (files took 0.39739 seconds to load)
1 example, 0 failures

Randomized with seed 55076

After that we can merge gitlab-qa!169 (merged) and release a new gitlab-qa version.

What are the relevant issue numbers?

Fixes the GitLab part of gitlab-qa#316 (closed).

Does this MR meet the acceptance criteria?

Edited by Rémy Coutable

Merge request reports