Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !21040

Merged
Opened Aug 06, 2018 by Mike Greiling@mikegreiling🔴Maintainer5 of 7 tasks completed5/7 tasks

Keep Admin settings sections expanded after submitting form

  • Overview 2
  • Commits 2
  • Pipelines 3
  • Changes 31

What does this MR do?

Part of #35952 (closed). This changes the behavior of all of the forms within collapsable sections in the administrator settings page such that when submitted, the resulting page will render with the form section expanded.

Are there points in the code the reviewer needs to double check?

Submitting any form within the admin settings page should send you to the same page with the same section expanded. (before this, all sections would be collapsed after the form is submitted)

Why was this MR needed?

See issue description.

Screenshots (if relevant)

n/a

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Conforms to the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • [ ] Internationalization required/considered
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Part of #35952 (closed)

Edited Aug 06, 2018 by Filipa Lacerda
Assignee
Assign to
Reviewer
Request review from
11.2
Milestone
11.2 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab-foss!21040
Source branch: 35952-keep-admin-settings-open-after-submit

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.