Skip to content

Move xterm to a node dependency and remove it from vendor's folder

Filipa Lacerda requested to merge 25990-improve-web-terminal into master

What does this MR do?

  • Moves xterm to a node dependency
  • Adds focus on load

Screenshots (if relevant)

Screen_Shot_2018-08-03_at_14.18.37

How to test locally

  1. Set up Gitlab Runner with GDK
  2. Download the runner:
cd ~/Downloads
curl -L https://gitlab-runner-downloads.s3.amazonaws.com/25990-ci-web-terminal-2/binaries/gitlab-runner-darwin-amd64 --output runner 
chmod +x  runner
  1. Register the runner Set it up to http://localhost:300 and use shell as the executer
  2. start the runner ./runner -l debug run --config <path-to-gdk>/gitlab-runner-config.toml

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#25990 (closed) Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/49741

Edited by Filipa Lacerda

Merge request reports