Skip to content

Fix archived parameter for projects API

Peter Marko requested to merge siemens/gitlab-ce:fix-project-api-archived into master

What does this MR do?

Fixes a regression where the archived parameter is incorrectly applied to the projects finder.

Are there points in the code the reviewer needs to double check?

It changes default (but incorrect per spec) API behavior which is in place for 1,5 years. Currently without archived parameter only active projects are returned (so filter archived=false is incorrectly applied). The current default API behavior matches GUI behavior, however it's not possible to filter archived projects only via API (which is possible via GUI).

This MR replaces !17244 (closed) (from @razer6), which is un-maintained for last 5 months due to contributor inactivity. The code from that MR is refreshed and remaining open comments are implemented.

Why was this MR needed?

See discussions in #32301 (closed) and !17244 (closed)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #32301 (closed)

Edited by Rémy Coutable

Merge request reports