Skip to content

Update issue closing pattern

George Tsiolis requested to merge gtsiolis/gitlab-foss:update-issue-closing-pattern into master

What does this MR do?

Updates issue closing pattern so that consecutive issues are more flexible with that comma usage. This bothered me for a while since I usually type closing issues consecutively without a comma like the following:

Closes #X #Y #Z

Current pattern works for the following:

Closes #X
Closes #X, #Y, #Z
Closes #X, #Y, #Z
Closes #X, #Y and #Z
Closes #X , #Y and #Z
Closes #X, #Y, and #Z
Closes #X , #Y , and #Z

But not for the following:

Closes #X #Y #Z
Closes #X, #Y #Z
Closes #X #Y, #Z

This merge request changes the pattern so that it works for all the above.

Screenshots (if relevant)

Before After
issue-closing-pattern-before issue-closing-pattern-after

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/49166. Inspired by the work done in !17198 (merged).

Edited by Rémy Coutable

Merge request reports