Skip to content

Resolve "Toggle file comments in merge request does not update toggle buttons"

Filipa Lacerda requested to merge 48237-toggle-file-comments into master

What does this MR do?

Discussions were being toggled by jquery DOM querying them and toggling visibility but in Vue, only the open discussions will be in the DOM Fix includes:

  • Adds a getter to the store to get the expanded discussions
  • Adds an action to collapse a discussion
  • When the user clicks the button, all data needed is now accessible through a getter and we can dispatch an action to toggle the discussion within the state, instead of showing/hiding with jQuery
  • Removes hardcoded properties

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #48237 (closed)

Edited by Filipa Lacerda

Merge request reports