Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !20322

Resolve "do not set updated_at when creating note"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kia Mei Somabes requested to merge kiameisomabes/gitlab-ce:46930-fix-updated_at-if-created_at-is-set-note-api into master Jul 03, 2018
  • Overview 21
  • Commits 6
  • Pipelines 9
  • Changes 4

What does this MR do?

Using the Notes API, if created_at is supplied upon creation of the issue note, the updated_at will be updated as well to the current time. This leads to show that the note has been just edited even if the said note is said to be created some time ago.

This MR fixes that by making the updated_at the same as the created_at if that said field is supplied.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Fixes #46930 (closed)

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Closes #46930 (closed)

Edited Jul 12, 2018 by Rémy Coutable
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 46930-fix-updated_at-if-created_at-is-set-note-api