Skip to content

Rails5 fix Mysql comparison failure caused by milliseconds problem

Jasper Maes requested to merge jlemaes/gitlab-ce:rails5-fix-48432 into master

What does this MR do?

last_resolved_note sorts in memory and since Rails 5 rounds datetimes before saving we have to use timecop to resolve these discussions so the in memory sorting still works.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #48432 (closed)

Edited by Rémy Coutable

Merge request reports