Skip to content

Rails 5 fix Capybara::ElementNotFound: Unable to find visible css #modal-revert-commit

Jasper Maes requested to merge jlemaes/gitlab-ce:rails5-fix-48140 into master

What does this MR do?

Add an extra wait_for_requests in two failing Rails5 feature specs. Not sure why this is needed for Rails 5 though.. I see some overlapping requests in the logs that are consecutive in Rails 4.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #48140 (closed) and #48139 (closed)

Edited by Rémy Coutable

Merge request reports