Resolve "[Rails5] expected the response to have status code :ok but it was 404"
requested to merge blackst0ne-rails5-expected-the-response-to-have-status-code-ok-but-it-was-404 into master
What does this MR do?
Since Rails 5 request.format gets set by extension if it's not explicitly set.
That means artifacts_controller#file no longer works as expected.
This MR explicitly sets request.format for artifacts_controller#file.
Are there points in the code the reviewer needs to double check?
No.
Why was this MR needed?
Screenshots (if relevant)
No.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
Conform by the merge request performance guides -
Conform by the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
End-to-end tests pass ( package-and-qamanual pipeline job)
What are the relevant issue numbers?
Closes #48008 (closed)
Edited by Rémy Coutable