Skip to content

Rails5 fix update_attribute usage not causing a save

Jasper Maes requested to merge jlemaes/gitlab-ce:rails5-fix-47960 into master

What does this MR do?

Replaces update_attribute with update_attributes to make sure the import_status is saved. Rails 5 does a changed? check before calling save: https://github.com/rails/rails/blob/v5.0.7/activerecord/lib/active_record/persistence.rb#L264. This behaviour is reverted in the 5-0-stable branch, but is still unreleased: https://github.com/rails/rails/blob/5-0-stable/activerecord/lib/active_record/persistence.rb#L259.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #47960 (closed)

Edited by Rémy Coutable

Merge request reports