Skip to content

[Rails5] Explicitly set request.format for blob_controller

blackst0ne requested to merge blackst0ne-rails5-fix-blob-requests-format into master

What does this MR do?

In Rails 4.2 if params[:format] is empty, Rails set it to :html.
But since Rails 5.0 the framework now looks for an extension.

E.g. for blob/master/CHANGELOG.md in Rails 4 the format would be :html, but in Rails 5 on it'd be :md.

This MR explicitly sets the :html format for all requests unless :format is set by a client e.g. by JS for XHR requests.

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

Migration to Rails 5.0.

Screenshots (if relevant)

No.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #47921 (closed)

Edited by Rémy Coutable

Merge request reports