Skip to content

Deny repository disk access in development and test

Jacob Vosmaer requested to merge gitaly-disk-access-4 into master

What does this MR do?

Follow-up to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19363 and !19437 (merged).

We have a feature flag that makes it an exception to access Git repositories directly, instead of via Gitaly. With this change this feature flag becomes active in test and development but not in production.

There is still unmigrated code that accesses repositories directly; this code is now fenced with allow_disk_access blocks.

Via https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6119 I am ensuring that the 'deny disk access' feature remains disabled in gitlab-ee test and development. I expect there to be extra code that needs to be fenced in gitlab-ee; I will resolve that in a follow-up MR.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Douwe Maan

Merge request reports