Skip to content

Find and mark more Git disk access locations, part 2

Jacob Vosmaer requested to merge gitaly-disk-access-3 into master

What does this MR do?

Follow-up to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19363

This marks a few more places in our code with 'allow disk access' blocks in preparation for making it an exception to directly access Git repositories.

While working on this I ended up moving some code, which then prompted me to change how we handle Git hooks during tests. Instead of trying to delete them from every repo the tests create, I made it so that the gitlab-shell hooks in tmp/tests/gitlab-shell/hooks are no-ops that always pass.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Jacob Vosmaer

Merge request reports