Skip to content

Use RequestStore to memoize Flipper features so that memoized values are cleared between requests

Rémy Coutable requested to merge fix-feature-memoization into master

What does this MR do?

This improves https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18490 by using RequestStore to memoize Flipper features so that memoized values are cleared between requests.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

This was discovered by @jacobvosmaer-gitlab while developing locally. That could lead to features toggle not up-to-date until Unicorn processes are restarted.

Fortunately, https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18490 hasn't been shipped in a tagged release yet so we're still on time to fix that.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Rémy Coutable

Merge request reports