Skip to content

Resolve "gitlab is not sending ObjectStore timeout value to workhorse"

What does this MR do?

When workhorse asks for an object storage preauthorized requests we are not sending a Timeout value.

The default value in workhorse is 6 minutes and many users of gitlab.com with a slow connection are not able to upload LFS objects.

Are there points in the code the reviewer needs to double check?

We are also adding 15 minutes to the expire time because workhorse perform some cleanup operation using pre-signed URLs. Such cleanup must be allowed also after a timeout error.

Why was this MR needed?

See #46917 (closed) users are reporting inability to push LFS objects due to the 6 minutes timeout

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #46917 (closed)

Edited by Kamil Trzciński

Merge request reports