Resolve "gitlab is not sending ObjectStore timeout value to workhorse"
What does this MR do?
When workhorse
asks for an object storage preauthorized requests we are not sending a Timeout
value.
The default value in workhorse
is 6 minutes and many users of gitlab.com with a slow connection are not able to upload LFS objects.
Are there points in the code the reviewer needs to double check?
We are also adding 15 minutes to the expire time because workhorse
perform some cleanup operation using pre-signed URLs.
Such cleanup must be allowed also after a timeout error.
Why was this MR needed?
See #46917 (closed) users are reporting inability to push LFS objects due to the 6 minutes timeout
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
Conform by the merge request performance guides -
Conform by the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #46917 (closed)
Edited by Kamil Trzciński