Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !18570
Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Merged
Created Apr 24, 2018 by Bob Van Landuyt@reprazent🔶Maintainer7 of 15 tasks completed7/15 tasks
  • Review changes

  • Download
  • Email patches
  • Plain diff

Enforce application wide terms

  • Overview 136
  • Commits 10
  • Pipelines 26
  • Changes 61

What does this MR do?

This adds the ability for admins to enforce terms in application settings:

Screen_Shot_2018-04-30_at_12.09.55

When the feature is enabled, users are presented with a ToS that they need to accept in order to continue using the web application.

Screen_Shot_2018-05-04_at_10.29.44

Every authenticated request will redirect to the terms page when the user did not accept the terms, after the user accepts they are directed back to where they were going.

API & Git operations are currently not affected.

TODO

  • Add a TermPolicy that can be checked to show/hide the correct buttons on the terms page. That way we can block some permissions that would otherwise result in a redirect.
  • Store the accepted_terms on the user instead of a boolean. That might be required later to enforce users to accept updated terms but it might be hard to migrate, so we'd better do it now.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/44798

Edited May 04, 2018 by Filipa Lacerda
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bvl-enforce-terms