Skip to content

Improve issue note dropdown and merge request button

George Tsiolis requested to merge gtsiolis/gitlab-foss:fix/improve-issue-note-dropdown into master

What does this MR do?

  1. Changes issue Create merge request/branch button to secondary button (btn-new btn-inverted).
  2. Removes unnecessary padding from issue Comment/Start discussion button.

Are there points in the code the reviewer needs to double check?

UX: Check if it's ok to have 2 secondary buttons on the same view.

FE: Note button has been part of CommentForm vue component for a while (app/assets/javascripts/notes/components/comment_form.vue). Check if _comment_button.haml is still used (app/views/shared/notes/_comment_button.html.haml). This partially updates the style of the create mr widget within issue template. This will probably transition to a vue component soon. Upon refactor evaluate #42460 (moved).

/cc @filipa @iamphill

Screenshots (if relevant)

Create mr button (BEFORE) Create mr button (AFTER)
Screen_Shot_2018-01-29_at_00.17.46 Screen_Shot_2018-01-29_at_00.07.04

Does this MR meet the acceptance criteria?

  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
Edited by George Tsiolis

Merge request reports