Ensure `Namespace`'s is namespaced in `Gitlab::Kubernetes::Helm#initialize` and fix a transient failing spec due to that
requested to merge 40746-broken-master-due-to-failure-in-spec-services-clusters-applications-schedule_installation_service_spec-rb into master
This fixes a transient failure caused by a constant not namespaced. Namespace
would resolve to the top-level Namespace
constant in Gitlab::Kubernetes::Helm#initialize
while the correct constant in Gitlab::Kubernetes::Namespace
.
As a result, CI was failing but locally the spec could pass because an ActiveRecord issue raised because of the wrong namespacing would be silently swallowed, thus skipping the HTTP calls that should have been made by Gitlab::Kubernetes::Namespace#exists?
and @kubeclient.create_pod
in Gitlab::Kubernetes::Helm#install
What are the relevant issue numbers?
Closes #40746 (closed)
Edited by Rémy Coutable