Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !15105

Adds callback function to initial cluster request

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Filipa Lacerda requested to merge 39639-clusters-poll into master Oct 31, 2017
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 2

What does this MR do?

Adds callback function to initial cluster request in non visible page, currently although we are doing the first request we are not showing anything to the user.

The goal is to:

  • Poll only when the page is visible
  • In case the user opens the page in a new non visible tab, make the first request without polling
  • Stop polling when page is not visible
  • Restart polling when page becomes visible again

We were doing the above, but we were not updating the UI on the first request when the page was not visible.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Review
    • Has been reviewed by Frontend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together

What are the relevant issue numbers?

Closes #39639 (closed)

/cc @MadLittleMods

Edited Oct 31, 2017 by Filipa Lacerda
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 39639-clusters-poll