Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !14960

Change default disabled merge request widget message to be more general

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eric Eastwood requested to merge 39188-change-default-disabled-merge-message into master Oct 19, 2017
  • Overview 14
  • Commits 1
  • Pipelines 3
  • Changes 3

What does this MR do?

EE MR, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3180

Change default disabled merge request widget message to be more general

Before After

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

The message about pipelines not succeeding yet is not accurate when we can't merge because of approvers.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together

What are the relevant issue numbers?

Closes #39188 (closed)

Edited Oct 27, 2017 by Filipa Lacerda
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 39188-change-default-disabled-merge-message