Skip to content

Replace the 'project/merge_requests.feature' spinach test with an rspec analog

blackst0ne requested to merge replace_project_merge_requests.feature into master

What does this MR do?

This MR moves all the test from the features/project/merge_requests.feature spinach spec to an rspec analog.

Additional information

While migrating, I figured out there were two scenarios that check the same things:

  @javascript
  Scenario: I comment on a line of a commit in merge request
    Given project "Shop" have "Bug NS-05" open merge request with diffs inside
    And I visit merge request page "Bug NS-05"
    And I click on the commit in the merge request
    And I leave a comment like "Line is wrong" on diff in commit
    And I switch to the merge request's comments tab
    Then I should see a discussion has started on commit diff

  @javascript
  Scenario: I comment on a commit in merge request
    Given project "Shop" have "Bug NS-05" open merge request with diffs inside
    And I visit merge request page "Bug NS-05"
    And I click on the commit in the merge request
    And I leave a comment on the diff page in commit
    And I switch to the merge request's comments tab
    Then I should see a discussion has started on commit

So I removed the former.

I removed the scenario

  @javascript
  Scenario: I can close merge request after commenting
    Given I visit merge request page "Bug NS-04"
    And I leave a comment like "XML attached"
    Then I should see comment "XML attached"
    And I click link "Close"
    Then I should see closed merge request "Bug NS-04"

beacuse I think it's overtesting. We already have tests for ability to close a merge request.

Why was this MR needed?

This is a part of the spinach removal campaign.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#23036 (closed)

Edited by blackst0ne

Merge request reports