Replace all Spinach tests with Rspec feature tests
We decided earlier this year (in #14121 (closed)) to stop writing new Spinach feature tests. I wanted to open an issue about replacing all the Spinach tests with Rspec feature tests where relevant.
Here's a list of all the Spinach test files and how long they took to execute for a randomly chosen commit, it's probably a good idea to start with the fastest/smallest specs first if you want an easy MR:
Here are all current spinach specs sorted by lines of code.
|Spec||Lines of code||Replacement status|
|features/admin/license.feature||39||Replaced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5477|
|features/group_hooks.feature||37||Replaced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5515|
|features/groups_management.feature||23||Replaced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5516|
|features/group_active_tab.feature||17||Replaced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5554|
|features/admin/emails.feature||17||Replaced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5513|
|features/project/issues/weight.feature||11||Replaced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5194|
|features/admin/push_rules.feature||9||Replaced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5512|
|features/project/elastic/*.feature||Replaced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4983|
These should be done one-at-a-time and we should make sure we're not duplicating existing RSpec feature tests.
Some resources to help newcomers get going: