Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 2
    • Merge requests 2
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !14535

Fix bottom spacing for dropdowns that open upwards

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eric Eastwood requested to merge 38187-38315-fix-dropdown-open-top-bottom-spacing into master Sep 27, 2017
  • Overview 14
  • Commits 1
  • Pipelines 5
  • Changes 7

What does this MR do?

Fix bottom spacing for dropdowns that open upwards

Before After
Before After

Are there points in the code the reviewer needs to double check?

  • What spacing do we actually want?
    • I set it to 4px based on the top navigation margin for dropdowns.
  • Are there other dropdowns that open upwards to check?

Why was this MR needed?

It looks like like the margin gap was introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13584/diffs#4b8ec5ff8ab825db349011c80b5bc9f401b2085d_731_731 for dropdowns that position below so they aren't covered up by the Chrome address hint.

https://gitlab.com/gitlab-org/gitlab-ce/issues/38315#note_41279736

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/38187, https://gitlab.com/gitlab-org/gitlab-ce/issues/38315

Edited Oct 03, 2017 by Eric Eastwood
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 38187-38315-fix-dropdown-open-top-bottom-spacing