Skip to content

Clean up redirect routes that conflict with regular routes

Michael Kozono requested to merge mk-delete-conflicting-redirects-mysql into master

What does this MR do?

Deletes any redirect routes that conflict with regular routes.

Are there points in the code the reviewer needs to double check?

@yorickpeterse Would this query be too slow on GitLab.com? Should I do some kind of batching in a background migration?

Why was this MR needed?

This is needed because the conflicting redirect route scope had a bug in which we did not match case insensitively on Postgres. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13357.

Screenshots (if relevant)

$ bundle exec rake db:migrate
== 20170823140235 DeleteConflictingRedirectRoutes: migrating ==================
-- Clean up redirect routes that conflict with regular routes.
   See initial bug fix: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13357
-- Deleted 3 redirect routes that were conflicting with routes.
== 20170823140235 DeleteConflictingRedirectRoutes: migrated (0.0015s) =========

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/36229

Edited by Michael Kozono

Merge request reports