Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !13721

Fix displaying events of removed events and events without commit messages

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Yorick Peterse requested to merge fix-push-events-branch-removals into master Aug 21, 2017
  • Overview 10
  • Commits 1
  • Pipelines 3
  • Changes 7

What does this MR do?

This fixes the problems listed in:

  • https://gitlab.com/gitlab-org/gitlab-ce/issues/36722
  • https://gitlab.com/gitlab-org/gitlab-ce/issues/36685

When we display events of removed branches/tags we no longer show the commit details (commit ID + message), instead we display the events inline:

Screenshot_from_2017-08-21_17-03-05

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
Edited Aug 23, 2017 by Sean McGivern
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-push-events-branch-removals