Make Markdown autocomplete dropdowns style consistent
Merge request reports
Activity
mentioned in issue #28921 (closed)
added 1 commit
- 3a6ae7da - Make Markdown autocomplete dropdown style consistent
@cperessini Could you please have a look at this? I'm not sure if we need padding at the top and bottom of the dropdown as we have it for other places.
assigned to @cperessini
@winh Yeah, we should add the padding here too so all dropdowns are consistent
Don't know if you got around to that part yet, but the matching string in the second dropdown still turns white. We shouldn't change the color on hover, just make it bold
@cperessini Thank you!
assigned to @winh
We shouldn't change the color on hover, just make it bold
@cperessini Should we still change the color when not hovering?
@cperessini By the way, there is a bug with highlighting the matching string: https://gitlab.com/gitlab-org/gitlab-ce/issues/32726 So we could consider removing the highlight altogether.
Edited by Inactive Accountadded 1 commit
- e716f3fe - Make Markdown autocomplete dropdown style consistent
assigned to @cperessini
Should we still change the color when not hovering?
@winh what do you mean, not showing the grey background? It's added to the option that will be applied when you hit TAB or Enter, so it's good to have it.
I think buggy highlighting is better than no highlighting. It'd be better to fix the bug than to remove the feature.
I think buggy highlighting is better than no highlighting
@cperessini ok, I have added screenshots to the description to reflect that. Can I get your approval / LGTM?
Edited by Inactive Account@winh One last thing, can you make the resting highlighted text black instead of blue?
can you make the resting highlighted text black instead of blue?
@cperessini Sure, changed now.
added 1 commit
- 759f744f - Make Markdown autocomplete dropdown style consistent
added 1 commit
- 759f744f - Make Markdown autocomplete dropdown style consistent
Looks good @winh, thanks!
assigned to @winh
added 451 commits
-
759f744f...07a4cf41 - 450 commits from branch
master
- 4a579872 - Make Markdown autocomplete dropdown style consistent
-
759f744f...07a4cf41 - 450 commits from branch
added 451 commits
-
759f744f...07a4cf41 - 450 commits from branch
master
- 4a579872 - Make Markdown autocomplete dropdown style consistent
-
759f744f...07a4cf41 - 450 commits from branch
added 1 commit
- 5fc98577 - Make Markdown autocomplete dropdown style consistent
Builds finally
... @annabeldunstone Can you please review?assigned to @annabeldunstone
LGTM! Thanks @winh
mentioned in commit a623446a
mentioned in merge request !13676 (merged)