Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !12371

don't show "Someone edited the issue" warning when saving issue

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon Knox requested to merge 33904-edit-issue-warning into master Jun 22, 2017
  • Overview 5
  • Commits 1
  • Pipelines 2
  • Changes 2

What does this MR do?

Fixes a race condition with submitting changes and the Poll for changes. The flash was caused by changes being saved, and the Poll responding before the form success state was rendered.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Warning was flashing on screen briefly after clicking Save when editing issue inline

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • [ ] Documentation created/updated
  • [ ] API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes #33904 (closed)

Edited Jun 22, 2017 by Simon Knox
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 33904-edit-issue-warning