Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Packages
    • Packages
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issues
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !10467

Merged
Opened Apr 05, 2017 by Timothy Andrew@timothyandrew49 of 49 tasks completed49/49 tasks
  • Report abuse
Report abuse

Resolve "Deleting a user shouldn't delete associated records"

  • Overview 6
  • Commits 8
  • Pipelines 8
  • Changes 13

What does this MR do?

Supplement #12726 (closed)/!7393 (merged) by migrating a user's merge requests, notes, award emoji, and abuse reports to the ghost user before the user is destroyed.

Are there points in the code the reviewer needs to double check?

Tasks

  • Implementation
    • Refactor / general cleanup
    • Migrate
      • Merge requests
      • Notes
      • Abuse reports
        • When User A reports an "abuse report" against User B, and User A is blocked, the abuse report's target changes to User A. Why? (#30514 (closed))
      • Award emoji
        • Is this possible with the current ghost user implementation?
  • Tests
    • Added
    • Passing
  • Verification
    • Make sure no uniqueness validations are going to conflict with the ghost user
      • Award emoji
      • Merge requests
      • Notes
      • Abuse reports
    • Verify from the UI
      • Merge requests
      • Notes
        • Merge request
        • Issue
        • Snippet
      • Abuse reports
      • Award emoji
        • Make sure the award emoji uniqueness change doesn't break anything in the UI
          • Snippet
          • Note
            • Merge request
            • Issue
            • Snippet
          • Issues
          • Merge requests
  • Meta
    • CHANGELOG entry created
    • API support added
    • Branch has no merge conflicts with master
    • Squashed related commits together
    • Added screenshots
    • Documentation added/updated
    • Check for clean merge with EE
      • Create EE branch
      • Create EE merge request
      • Make sure ee_compat_check passes
  • Review
    • Miniboss
    • Endboss
  • Wait for merge

What are the relevant issue numbers?

  • Closes #28695 (closed)
  • Closes #30514 (closed)
  • EE merge request to resolve conflicts: gitlab-org/gitlab-ee!1581
Assignee
Assign to
9.1
Milestone
9.1
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-foss!10467

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.