Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !10467

Resolve "Deleting a user shouldn't delete associated records"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Timothy Andrew requested to merge 28695-move-all-associated-records-to-ghost-user into master Apr 05, 2017
  • Overview 6
  • Commits 8
  • Pipelines 8
  • Changes 13

What does this MR do?

Supplement #12726 (closed)/!7393 (merged) by migrating a user's merge requests, notes, award emoji, and abuse reports to the ghost user before the user is destroyed.

Are there points in the code the reviewer needs to double check?

Tasks

  • Implementation
    • Refactor / general cleanup
    • Migrate
      • Merge requests
      • Notes
      • Abuse reports
        • When User A reports an "abuse report" against User B, and User A is blocked, the abuse report's target changes to User A. Why? (#30514 (closed))
      • Award emoji
        • Is this possible with the current ghost user implementation?
  • Tests
    • Added
    • Passing
  • Verification
    • Make sure no uniqueness validations are going to conflict with the ghost user
      • Award emoji
      • Merge requests
      • Notes
      • Abuse reports
    • Verify from the UI
      • Merge requests
      • Notes
        • Merge request
        • Issue
        • Snippet
      • Abuse reports
      • Award emoji
        • Make sure the award emoji uniqueness change doesn't break anything in the UI
          • Snippet
          • Note
            • Merge request
            • Issue
            • Snippet
          • Issues
          • Merge requests
  • Meta
    • CHANGELOG entry created
    • API support added
    • Branch has no merge conflicts with master
    • Squashed related commits together
    • Added screenshots
    • Documentation added/updated
    • Check for clean merge with EE
      • Create EE branch
      • Create EE merge request
      • Make sure ee_compat_check passes
  • Review
    • Miniboss
    • Endboss
  • Wait for merge

What are the relevant issue numbers?

  • Closes #28695 (closed)
  • Closes #30514 (closed)
  • EE merge request to resolve conflicts: gitlab-org/gitlab-ee!1581
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 28695-move-all-associated-records-to-ghost-user