Skip to content

Use google-protobuf 3.2.0.2

What does this MR do?

Update the google-protobuf gem to 3.2.0.2.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Google-protobuf 3.2.0 does not install properly on Debian 7 and Centos 6; manual intervention from administrators is needed to get the gem installed properly.

Google-protobuf 3.2.0.1 extended precompiled binary support down to glibc 2.12, removing the speedbump on Debian 7 and Centos 6. Unfortunately 3.2.0.1 contained files with incorrect permissions (not world-readable) which broke Omnibus deployments because there the GitLab application user does not own the gem files.

I think this is worth having in 9.0.0 because google-protobuf 3.2.0 is inconvenient to Debian 7 and Centos 6 users.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-com/infrastructure/issues/1354

https://github.com/google/protobuf/issues/2853

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9971

Merge request reports