@victorwu As far as I understand, the functionality here already exists. It is only about adding a button for it. Should we accept Community contributions?
What would that button be called? Something like "Quote this comment"? I too think that the quote and reply shortcut is not advertised very well and it's a super useful feature
What would that button be called? Something like "Quote this comment"? I too think that the quote and reply shortcut is not advertised very well and it's a super useful feature
IMHO, a "Reply" button would suffice. Users can expect (from email experience) that selected text will be cited when replying. What is actually missing right now is the Reply button. And there's no clue that the R key does the action.
I would prefer to have a "Reply" button next to the comment, possibly in the "More options" hamburger menu. When that is pressed, the entire comment is quoted ready for me to adjust. Coming from Rietveld (and email), that was what I was expecting. There are often more than one thing raised in a comment which I want to address.
I suppose the highlight and quote context button / hotkey isn't mutually exclusive with that however, I wouldn't mind there being two ways to do it. In my opinion, replying to a comment in a code review is such a common thing to do, it should be as convenient as possible.
@dennis I agree since replying has been implemented now, so only the option for better replying when quoting is outstanding imho. In that case however there are already issues covering that referenced here, correct?
So I think if @rpadovani agrees this can be closed then?
I don't think this can be closed yet. There is no button to quote a comment yet, something that acts as the r shortcut. While shortcuts are cool, majority of people use GUIs
There is #52002 (moved) but you are right, this is not a button to quote the whole comment. But it works similar to the r shortcut, which also requires you to select the text before, afaik. So since there already seems to be an issue for a GUI version of the r shortcut, would you still prefer to have an additional button to be able to qoute a complete comment easily?
I would prefer to have a "Reply" button next to the comment, possibly in the "More options" hamburger menu. When that is pressed, the entire comment is quoted ready for me to adjust.
Alright, so after reading again, at least @kzar prefers having a seperate button for this, however I guess one would need to see, whether it is still needed since discussions are now available for comments and whether it is wanted in addition to having discussions already.
I'm just trying out the "Reply to comment" button here. Well, it seems like it doesn't quote the text... that's really the feature I'd like to exposed. When responding to a large message (email or otherwise), I like to quote various parts and respond in line.
Why is it here I see a "Comment" button when I reply to a comment, but elsewhere I see "Start a review" and "Add comment now"? Is it because the other place is a MR or because I have higher privileges there?
Anyway, apart from the quoting part, my issue is that I want to reply to a comment without starting a frigging review.
GitLab is moving all development for both GitLab Community Edition
and Enterprise Edition into a single codebase. The current
gitlab-ce repository will become a read-only mirror, without any
proprietary code. All development is moved to the current
gitlab-ee repository, which we will rename to just gitlab in the
coming weeks. As part of this migration, issues will be moved to the
current gitlab-ee project.
If you have any questions about all of this, please ask them in our
dedicated FAQ issue.
Using "gitlab" and "gitlab-ce" would be confusing, so we decided to
rename gitlab-ce to gitlab-foss to make the purpose of this FOSS
repository more clear
I created a merge requests for CE, and this got closed. What do I
need to do?
Everything in the ee/ directory is proprietary. Everything else is
free and open source software. If your merge request does not change
anything in the ee/ directory, the process of contributing changes
is the same as when using the gitlab-ce repository.
Will you accept merge requests on the gitlab-ce/gitlab-foss project
after it has been renamed?
No. Merge requests submitted to this project will be closed automatically.
Will I still be able to view old issues and merge requests in
gitlab-ce/gitlab-foss?
Yes.
How will this affect users of GitLab CE using Omnibus?
No changes will be necessary, as the packages built remain the same.
How will this affect users of GitLab CE that build from source?
Once the project has been renamed, you will need to change your Git
remotes to use this new URL. GitLab will take care of redirecting Git
operations so there is no hard deadline, but we recommend doing this
as soon as the projects have been renamed.
Where can I see a timeline of the remaining steps?