Comment on pictures inside a comment (design discussions)
original comment/issue https://gitlab.com/gitlab-org/gitlab-ce/issues/2641#note_18302491
first do commenting on a picture diff https://gitlab.com/gitlab-org/gitlab-ee/issues/1768
As the other section is taken care of we now can focus on the other side of this issue, which is probably even more important! This is the part which is really important to design driven discussion, which generally happens only in issues.
IMO we should not think about this the same way as code. We are handling visual information and as @brycepj explained.. a lot of versions (if we'd think about it the same way as code) would make it hard to compare or point out exactly which change we are discussing.
My plan is as follows:
- Reuse the sub discussions UI from Merge Requests
It has the added benefit to be able to be resolved and it allows for focused discussion.
- 1 file focused sub discussion or 2 files user invoked mini diff discussion
A user will be able to select 1 or 2 images from the previous discussions. From it they will be able to invoke a sub discussion, which will behave similarly to the pictures inside a commit example and look like:
It will of course feature the same collapsed/expanded functionality. Plus if 2 images are selected it will be a diff with 2-up/swipe/onion skin available:
Now we come to the part that is still kind of fuzzy. How will a user be able to select images, in order to start a discussion from them? An option would be a media tab in the issue discussion:
The media tab will serve as a mini repository for an issue discussion. Making it possible to upload images and only afterwards begin a diff sub discussion on them.
However, we could also just be able to select these sort of images from the discussion thread itself.. The way I envisioned it is that you would have a similar functionality to review products in web stores like this.
That could look like:
When clicking the button, we would got to our newly created sub discussion inside the general issue discussion.. there we will be able to comment.
If a sub discussion is started but no comment is put in, it will be deleted.. as if it never was.
As the original issue is a ~moonshots , i think this one is in the same range!