Skip to content

CI: Simplify `danger-review` job configuration

Peter Leitzen requested to merge pl-danger-review-simplify into main

What does this MR do?

This MR simplifies the configuration of danger-review by removing it completely. See gitlab-org/quality/pipeline-common!212 (merged).

Note that the version of gitlab-dangerfiles is still pinned to ~> 3.0 but could be tweaked to use the latest version by removing:

danger-review:
  variables:
    GITLAB_DANGERFILES_VERSION: "~> 3.0"

Related issues

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up to date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: setup a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Peter Leitzen

Merge request reports