Skip to content

Don't require projects to contain Gemfile when using danger-review job

Peter Leitzen requested to merge pl-danger-review-no-gemfile into master

What does this MR do?

This MR triggers bundle init and adds gitlab-dangerfiles as a dependencies for the job danger-review if the project does not contain Gemfile.

Pin version of danger when GITLAB_DANGERFILES_VERSION is set.

Check-list

Project with Gemfile and Gemfile.lock Project without Gemfile - latest version 3.1.0 Project without Gemfile - pinned version 3.0.0
https://gitlab.com/gitlab-org/quality/pipeline-common/-/jobs/2573854313#L106 Screenshot_from_2022-06-10_13-28-00 https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/2573971479#L109 Screenshot_from_2022-06-10_13-28-11 https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/2573994940#L109 Screenshot_from_2022-06-10_13-28-18
Edited by Peter Leitzen

Merge request reports