Optionally disable creation of a NAT

John Jarvisrequested to merge
jarv/optionally-disable-nat into master

What does this MR do?

When creating a NAT in GET, we default to ALL_SUBNETWORKS_ALL_IP_RANGES.

It is not allowed to have more than one of these types of NAT in a single VPC, but we don't yet support network options to deploy in a specific VPC https://gitlab.com/gitlab-org/quality/gitlab-environment-toolkit/-/issues/188

For this reason, we will need to setup a NAT outside of GET for deploying multiple reference architectures in a single GCP project (in a single VPC).

This adds a variable to disable the NAT in case you are bringing in one outside of GET.

Related issues

Author's checklist

When ready for review, the Author applies the workflowready for review label:

  • Merge request:
    • Merge Request Title and Description are up to date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: setup a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.

Merge request reports